Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2410193005: Remove unused widget handler overrides (Closed)

Created:
4 years, 2 months ago by dsinclair
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused widget handler overrides This CL removes override points from the widget hander classes. Committed: https://pdfium.googlesource.com/pdfium/+/a30537f8b07492489e81414c9037af90c8b1448e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -101 lines) Patch
M fpdfsdk/cpdfsdk_annothandlermgr.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannothandler.h View 3 chunks +0 lines, -6 lines 0 comments Download
M fpdfsdk/cpdfsdk_baannothandler.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.h View 3 chunks +0 lines, -6 lines 0 comments Download
M fpdfsdk/cpdfsdk_widgethandler.cpp View 4 chunks +0 lines, -13 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.h View 3 chunks +0 lines, -6 lines 0 comments Download
M fpdfsdk/cpdfsdk_xfawidgethandler.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/formfiller/cffl_formfiller.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M fpdfsdk/formfiller/cffl_interactiveformfiller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M fpdfsdk/formfiller/cffl_interactiveformfiller.cpp View 2 chunks +1 line, -18 lines 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.h View 1 chunk +0 lines, -3 lines 0 comments Download
M fpdfsdk/formfiller/cffl_listbox.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M fpdfsdk/ipdfsdk_annothandler.h View 3 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 2 months ago (2016-10-12 14:09:51 UTC) #4
Tom Sepez
lgtm
4 years, 2 months ago (2016-10-12 16:11:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410193005/1
4 years, 2 months ago (2016-10-12 16:12:31 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 16:12:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/a30537f8b07492489e81414c9037af90c8b1...

Powered by Google App Engine
This is Rietveld 408576698