Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2410193003: Attempt to submit the click action directly in the pinch-zoom test. (Closed)

Created:
4 years, 2 months ago by dtapuska
Modified:
4 years, 2 months ago
Reviewers:
Navid Zolghadr
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to submit the click action directly in the pinch-zoom test. The click action appears to fail sometimes. Call it directly to see if this gets rid of the flakes. Remove the slow test as it didn't help. BUG=652343 Committed: https://crrev.com/e93ec7ca45cf8760feb359a51e9b4d909231d79e Cr-Commit-Position: refs/heads/master@{#424481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/LayoutTests/SlowTests View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/pointerevents/pointerevent_touch-action-pinch_zoom_touch.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
dtapuska
PTAL
4 years, 2 months ago (2016-10-11 15:29:16 UTC) #3
Navid Zolghadr
LGTM Is this like a temporary change to see if it solves the flake or ...
4 years, 2 months ago (2016-10-11 15:59:18 UTC) #4
dtapuska
On 2016/10/11 15:59:18, Navid Zolghadr wrote: > LGTM > Is this like a temporary change ...
4 years, 2 months ago (2016-10-11 16:01:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410193003/1
4 years, 2 months ago (2016-10-11 17:01:52 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 17:56:05 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 17:58:07 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e93ec7ca45cf8760feb359a51e9b4d909231d79e
Cr-Commit-Position: refs/heads/master@{#424481}

Powered by Google App Engine
This is Rietveld 408576698