Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2410183002: PPC/s390: [stubs] Simplify the ArrayConstructorStub. (Closed)

Created:
4 years, 2 months ago by JaideepBajwa
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [stubs] Simplify the ArrayConstructorStub. Port 9192db20370ad43954455007dc808b04dbff498b Original commit message: Remove the special side channel from the CallICStub to the ArrayConstructorStub and make the CallICStub always use the general entry point. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= LOG=N Committed: https://crrev.com/82b10341c8d327e208545859e6003e0dd510c2dd Cr-Commit-Position: refs/heads/master@{#40183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -84 lines) Patch
M src/ppc/code-stubs-ppc.cc View 3 chunks +16 lines, -42 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 3 chunks +16 lines, -42 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 2 months ago (2016-10-11 15:16:16 UTC) #1
john.yan
lgtm
4 years, 2 months ago (2016-10-11 15:47:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410183002/1
4 years, 2 months ago (2016-10-11 16:21:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 16:48:58 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 16:49:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82b10341c8d327e208545859e6003e0dd510c2dd
Cr-Commit-Position: refs/heads/master@{#40183}

Powered by Google App Engine
This is Rietveld 408576698