Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2410163005: Update chrome_rev (Closed)

Created:
4 years, 2 months ago by Roland McGrath
Modified:
4 years, 2 months ago
Reviewers:
erikchen, bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Update chrome_rev This updates chrome_rev and dependent entries in DEPS. BUG= none R=erikchen@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/be714d07cf63b5e59921348fa1d2a5e9dc3059e5

Patch Set 1 #

Patch Set 2 : libc++-static gone #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -25 lines) Patch
M DEPS View 1 5 chunks +14 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Roland McGrath
PTAL. It looks like some of the windows bots are not up at all, but ...
4 years, 2 months ago (2016-10-12 22:00:27 UTC) #4
erikchen
lgtm
4 years, 2 months ago (2016-10-12 22:06:48 UTC) #5
Roland McGrath
Committed patchset #2 (id:20001) manually as be714d07cf63b5e59921348fa1d2a5e9dc3059e5 (presubmit successful).
4 years, 2 months ago (2016-10-12 23:21:48 UTC) #9
bradn
4 years, 2 months ago (2016-10-13 04:55:15 UTC) #11
Message was sent while issue was closed.
Thanks Roland!
Sorry for the delay Erik.

Powered by Google App Engine
This is Rietveld 408576698