Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: content/renderer/render_widget.h

Issue 2410153005: Fix RenderView reuse issues when canceling a pending RenderFrameHost. (Closed)
Patch Set: Rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_proxy.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_widget.h
diff --git a/content/renderer/render_widget.h b/content/renderer/render_widget.h
index 0a9e9d1675b2ce298b703da93375c6444fe84ba3..7a449da02c131ed2c9a67a23855f9918938ce64a 100644
--- a/content/renderer/render_widget.h
+++ b/content/renderer/render_widget.h
@@ -164,7 +164,6 @@ class CONTENT_EXPORT RenderWidget
bool is_hidden() const { return is_hidden_; }
// Temporary for debugging purposes...
bool closing() const { return closing_; }
- bool is_swapped_out() { return is_swapped_out_; }
bool has_host_context_menu_location() {
return has_host_context_menu_location_;
}
@@ -182,6 +181,14 @@ class CONTENT_EXPORT RenderWidget
// ScreenInfo exposed so it can be passed to subframe RenderWidgets.
ScreenInfo screen_info() const { return screen_info_; }
+ // Sets whether this RenderWidget has been swapped out to be displayed by
+ // a RenderWidget in a different process. If so, no new IPC messages will be
+ // sent (only ACKs) and the process is free to exit when there are no other
+ // active RenderWidgets.
+ void SetSwappedOut(bool is_swapped_out);
+
+ bool is_swapped_out() { return is_swapped_out_; }
+
// Manage edit commands to be used for the next keyboard event.
const EditCommands& edit_commands() const { return edit_commands_; }
void SetEditCommandForNextKeyEvent(const std::string& name,
@@ -439,12 +446,6 @@ class CONTENT_EXPORT RenderWidget
blink::WebWidget* web_widget,
IPC::SyncMessage* create_widget_message);
- // Sets whether this RenderWidget has been swapped out to be displayed by
- // a RenderWidget in a different process. If so, no new IPC messages will be
- // sent (only ACKs) and the process is free to exit when there are no other
- // active RenderWidgets.
- void SetSwappedOut(bool is_swapped_out);
-
// Allows the process to exit once the unload handler has finished, if there
// are no other active RenderWidgets.
void WasSwappedOut();
« no previous file with comments | « content/renderer/render_frame_proxy.cc ('k') | content/renderer/render_widget.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698