Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

Issue 2410143003: Add currencySystem field to PaymentCurrencyAmount (Closed)
Patch Set: Add currencySystem field to PaymentCurrencyAmount Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentTestHelper.h » ('j') | third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
index 626cfa37c9b9a1dfd656f4cfc669d4af5cfe7446..7b140a1590f138db87efe1ea0f62e0b775dd01bf 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
@@ -98,6 +98,9 @@ std::ostream& operator<<(std::ostream& out, DetailsTestCase testCase) {
case PaymentTestDataCurrencyCode:
out << "currency ";
break;
+ case PaymentTestDataCurrencySystem:
+ out << "currencySystem ";
+ break;
case PaymentTestDataValue:
out << "value ";
break;
@@ -315,27 +318,27 @@ INSTANTIATE_TEST_CASE_P(
PaymentTestOverwriteValue,
"USD"),
DetailsTestCase(PaymentTestDetailTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"US1"),
DetailsTestCase(PaymentTestDetailTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"US"),
DetailsTestCase(PaymentTestDetailTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"USD0"),
DetailsTestCase(PaymentTestDetailTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"usd"),
DetailsTestCase(PaymentTestDetailTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"ANYSTRING"),
DetailsTestCase(PaymentTestDetailTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
""),
please use gerrit instead 2016/10/13 17:37:54 Please remove lines 317-340. These tests are no lo
pals 2016/10/14 14:41:21 Done.
@@ -344,27 +347,27 @@ INSTANTIATE_TEST_CASE_P(
PaymentTestOverwriteValue,
"USD"),
DetailsTestCase(PaymentTestDetailItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"US1"),
DetailsTestCase(PaymentTestDetailItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"US"),
DetailsTestCase(PaymentTestDetailItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"USD0"),
DetailsTestCase(PaymentTestDetailItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"usd"),
DetailsTestCase(PaymentTestDetailItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"ANYSTRING"),
DetailsTestCase(PaymentTestDetailItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
""),
please use gerrit instead 2016/10/13 17:37:54 Remove lines 346-369.
pals 2016/10/14 14:41:21 Done.
@@ -373,27 +376,27 @@ INSTANTIATE_TEST_CASE_P(
PaymentTestOverwriteValue,
"USD"),
DetailsTestCase(PaymentTestDetailShippingOption,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"US1"),
DetailsTestCase(PaymentTestDetailShippingOption,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"US"),
DetailsTestCase(PaymentTestDetailShippingOption,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"USD0"),
DetailsTestCase(PaymentTestDetailShippingOption,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"usd"),
DetailsTestCase(PaymentTestDetailShippingOption,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"ANYSTRING"),
DetailsTestCase(PaymentTestDetailShippingOption,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
""),
please use gerrit instead 2016/10/13 17:37:54 Remove lines 375-398.
pals 2016/10/14 14:41:21 Done.
@@ -402,27 +405,27 @@ INSTANTIATE_TEST_CASE_P(
PaymentTestOverwriteValue,
"USD"),
DetailsTestCase(PaymentTestDetailModifierTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"US1"),
DetailsTestCase(PaymentTestDetailModifierTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"US"),
DetailsTestCase(PaymentTestDetailModifierTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"USD0"),
DetailsTestCase(PaymentTestDetailModifierTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"usd"),
DetailsTestCase(PaymentTestDetailModifierTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"ANYSTRING"),
DetailsTestCase(PaymentTestDetailModifierTotal,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
""),
please use gerrit instead 2016/10/13 17:37:54 Remove lines 404-427.
pals 2016/10/14 14:41:21 Done.
@@ -431,27 +434,27 @@ INSTANTIATE_TEST_CASE_P(
PaymentTestOverwriteValue,
"USD"),
DetailsTestCase(PaymentTestDetailModifierItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"US1"),
DetailsTestCase(PaymentTestDetailModifierItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"US"),
DetailsTestCase(PaymentTestDetailModifierItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"USD0"),
DetailsTestCase(PaymentTestDetailModifierItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"usd"),
DetailsTestCase(PaymentTestDetailModifierItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"ANYSTRING"),
DetailsTestCase(PaymentTestDetailModifierItem,
- PaymentTestDataCurrencyCode,
+ PaymentTestDataCurrencySystem,
PaymentTestOverwriteValue,
"")));
please use gerrit instead 2016/10/13 17:37:54 Remove lines 433-456.
pals 2016/10/14 14:41:21 Done.
« no previous file with comments | « third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentTestHelper.h » ('j') | third_party/WebKit/Source/modules/payments/PaymentTestHelper.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698