Add currencySystem field to PaymentCurrencyAmount

third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/payments/PaymentsValidators.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "wtf/text/WTFString.h"
 #include <ostream>  // NOLINT
 
 namespace blink {
 namespace {
 
 struct TestCase {

[please use gerrit instead, 2016/10/12 23:35:50]

Please move the "TestCase" down to be immediately above the first place where
it's used. (Line 100-ish.)

[pals, 2016/10/13 09:30:38]

Done.

   TestCase(const char* input, bool expectedValid)
       : input(input), expectedValid(expectedValid) {}
   ~TestCase() {}
 
   const char* input;
   bool expectedValid;
 };
 
 std::ostream& operator<<(std::ostream& out, const TestCase& testCase) {
   out << "'" << testCase.input << "' is expected to be "
       << (testCase.expectedValid ? "valid" : "invalid");
   return out;
 }
 
-class PaymentsCurrencyValidatorTest : public testing::TestWithParam<TestCase> {
+struct CurrencyCodeTestCase {
+  CurrencyCodeTestCase(const char* code, const char* system, bool expectedValid)
+      : code(code), system(system), expectedValid(expectedValid) {}
+  ~CurrencyCodeTestCase() {}
+
+  const char* code;
+  const char* system;
+  bool expectedValid;
 };
 
+class PaymentsCurrencyValidatorTest
+    : public testing::TestWithParam<CurrencyCodeTestCase> {};
+
 const char* longString2048() {
   static char longString[2049];
   for (int i = 0; i < 2048; i++)
     longString[i] = 'a';
   longString[2048] = '\0';
   return longString;
 }
 
 const char* longString2049() {
   static char longString[2050];
   for (int i = 0; i < 2049; i++)
     longString[i] = 'a';
   longString[2049] = '\0';
   return longString;
 }
 
 TEST_P(PaymentsCurrencyValidatorTest, IsValidCurrencyCodeFormat) {
   String errorMessage;
   EXPECT_EQ(GetParam().expectedValid,
-            PaymentsValidators::isValidCurrencyCodeFormat(GetParam().input,
-                                                          &errorMessage))
+            PaymentsValidators::isValidCurrencyCodeFormat(
+                GetParam().code, GetParam().system, &errorMessage))
       << errorMessage;
   EXPECT_EQ(GetParam().expectedValid, errorMessage.isEmpty()) << errorMessage;
 
-  EXPECT_EQ(
-      GetParam().expectedValid,
-      PaymentsValidators::isValidCurrencyCodeFormat(GetParam().input, nullptr));
+  EXPECT_EQ(GetParam().expectedValid,
+            PaymentsValidators::isValidCurrencyCodeFormat(
+                GetParam().code, GetParam().system, nullptr));
 }
 
 INSTANTIATE_TEST_CASE_P(
     CurrencyCodes,
     PaymentsCurrencyValidatorTest,
     testing::Values(
         // Any string of at most 2048 characters can be a valid currency code
-        TestCase("USD", true),
-        TestCase("US1", true),
-        TestCase("US", true),
-        TestCase("USDO", true),
-        TestCase("usd", true),
-        TestCase("ANYSTRING", true),
-        TestCase("", true),
-        TestCase(longString2048(), true),
-        TestCase(longString2049(), false)));
+        CurrencyCodeTestCase("USD", "urn:iso:std:iso:4217", true),
+        CurrencyCodeTestCase("US1", "http://www.example.com", true),

[please use gerrit instead, 2016/10/12 23:35:50]

For each of the valid example.com currency systems test cases, please also add
one test case for "urn:iso:std:iso:4217" that is invalid. For example, add
"US1"/"urn:iso:std:iso:4217"/false test case on this line.

[pals, 2016/10/13 09:30:39]

Done.

+        CurrencyCodeTestCase("US", "http://www.example.com", true),
+        CurrencyCodeTestCase("USDO", "http://www.example.com", true),
+        CurrencyCodeTestCase("usd", "http://www.example.com", true),
+        CurrencyCodeTestCase("ANYSTRING", "http://www.example.com", true),
+        CurrencyCodeTestCase("", "http://www.example.com", true),
+        CurrencyCodeTestCase(longString2048(), "http://www.example.com", true),
+        CurrencyCodeTestCase(longString2049(),
+                             "http://www.example.com",
+                             false)));
 
 class PaymentsAmountValidatorTest : public testing::TestWithParam<TestCase> {};
 
 TEST_P(PaymentsAmountValidatorTest, IsValidAmountFormat) {
   String errorMessage;
   EXPECT_EQ(GetParam().expectedValid, PaymentsValidators::isValidAmountFormat(
                                           GetParam().input, &errorMessage))
       << errorMessage;
   EXPECT_EQ(GetParam().expectedValid, errorMessage.isEmpty()) << errorMessage;
 
@@ skipping 156 matching lines @@
         ShippingAddressTestCase("US", "", "", true),
         // Invalid shipping addresses
         ShippingAddressTestCase("", "", "", false),
         ShippingAddressTestCase("InvalidCountryCode", "", "", false),
         ShippingAddressTestCase("US", "InvalidLanguageCode", "", false),
         ShippingAddressTestCase("US", "en", "InvalidScriptCode", false),
         ShippingAddressTestCase("US", "", "Latn", false)));
 
 }  // namespace
 }  // namespace blink