Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: content/browser/web_contents/render_view_host_manager.cc

Issue 24101003: Make the RenderViewHostImpl update its visibility after a swap. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't show the new RWHV if WebContents is hidden. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_gtk.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/render_view_host_manager.cc
diff --git a/content/browser/web_contents/render_view_host_manager.cc b/content/browser/web_contents/render_view_host_manager.cc
index 00811167c6c5f99143aafecbe2c924eab7d91b09..1b019f4891f7c48bc427cabb4e535c522bcd2584 100644
--- a/content/browser/web_contents/render_view_host_manager.cc
+++ b/content/browser/web_contents/render_view_host_manager.cc
@@ -748,10 +748,10 @@ void RenderViewHostManager::CommitPending() {
// If the view is gone, then this RenderViewHost died while it was hidden.
// We ignored the RenderProcessGone call at the time, so we should send it now
// to make sure the sad tab shows up, etc.
- if (render_view_host_->GetView())
- render_view_host_->GetView()->Show();
- else
+ if (!render_view_host_->GetView())
delegate_->RenderProcessGoneFromRenderManager(render_view_host_);
+ else if (!delegate_->IsHidden())
+ render_view_host_->GetView()->Show();
// Hide the old view now that the new one is visible.
if (old_render_view_host->GetView()) {
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_gtk.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698