Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2410083004: X87: [stubs] Simplify the ArrayConstructorStub. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Simplify the ArrayConstructorStub. port 9192db20370ad43954455007dc808b04dbff498b (r40162) original commit message: Remove the special side channel from the CallICStub to the ArrayConstructorStub and make the CallICStub always use the general entry point. BUG= Committed: https://crrev.com/a8e4faf4ee205b38da975a7307ac6b084fb9e01f Cr-Commit-Position: refs/heads/master@{#40197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -40 lines) Patch
M src/x87/code-stubs-x87.cc View 3 chunks +16 lines, -40 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-12 05:39:55 UTC) #2
Weiliang
lgtm
4 years, 2 months ago (2016-10-12 06:50:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410083004/1
4 years, 2 months ago (2016-10-12 06:51:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410083004/1
4 years, 2 months ago (2016-10-12 07:33:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 07:35:49 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 07:36:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a8e4faf4ee205b38da975a7307ac6b084fb9e01f
Cr-Commit-Position: refs/heads/master@{#40197}

Powered by Google App Engine
This is Rietveld 408576698