Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2410083003: Add over allocated memory of fixed array sub types to fixed array type. (Closed)

Created:
4 years, 2 months ago by lpy
Modified:
4 years, 2 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add over allocated memory of fixed array sub types to fixed array type. The over allocated memory of fixed array type didn't equal to the sum of all fixed array sub types previously, this patch adds over allocated memory of fixed array sub types to fixed array type when we record fixed array sub type stats. BUG= LOG=N Committed: https://crrev.com/11e3ec3cdf82b25099497e8912c3983f20f32083 Cr-Commit-Position: refs/heads/master@{#40234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/heap/object-stats.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
lpy
PTAL.
4 years, 2 months ago (2016-10-11 22:18:31 UTC) #4
Michael Lippautz
lgtm
4 years, 2 months ago (2016-10-12 07:03:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410083003/1
4 years, 2 months ago (2016-10-12 16:47:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-12 16:50:39 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-12 16:51:03 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11e3ec3cdf82b25099497e8912c3983f20f32083
Cr-Commit-Position: refs/heads/master@{#40234}

Powered by Google App Engine
This is Rietveld 408576698