Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 241006: Reduce the number of unneeded dependencies.... (Closed)

Created:
11 years, 3 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews_googlegroups.com, kuchhal
Visibility:
Public.

Description

Reduce the number of unneeded dependencies. Split constants in common off so the projects that wants to pull that don't need to pull half-the-world. TEST=still compiles BUG=22926 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27296

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -29 lines) Patch
M chrome/chrome.gyp View 1 2 10 chunks +37 lines, -26 lines 0 comments Download
M chrome/common/json_value_serializer.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/installer.gyp View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/mini_installer.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
M-A Ruel
11 years, 3 months ago (2009-09-25 16:43:50 UTC) #1
bradn
11 years, 3 months ago (2009-09-25 17:22:55 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698