Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Issue 2410053002: Revert of bot_update/gclient: kill git fetch after timeout regardless of output. (Closed)

Created:
4 years, 2 months ago by tandrii(chromium)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of bot_update/gclient: kill git fetch after timeout regardless of output. (patchset #2 id:20001 of https://codereview.chromium.org/2293013002/ ) Reason for revert: didn't work. Original issue's description: > bot_update/gclient: kill git fetch after timeout regardless of output. > > Also spits out whatever output was produced by git fetch for debugging. > > BUG=635641 > R=machenbach@chromium.org,hinoka@chromium.org > > Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/db8b839320168ab4f5156399ecb275478c0aa2cd TBR=hinoka@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=635641 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/30d956272d1b850fbae28de1cbdb526995ee05ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -22 lines) Patch
M gclient_utils.py View 7 chunks +10 lines, -21 lines 0 comments Download
M tests/gclient_utils_test.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
tandrii(chromium)
Created Revert of bot_update/gclient: kill git fetch after timeout regardless of output.
4 years, 2 months ago (2016-10-11 12:17:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410053002/1
4 years, 2 months ago (2016-10-11 12:17:31 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 12:20:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/30d956272d1b85...

Powered by Google App Engine
This is Rietveld 408576698