Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: chrome/browser/ssl/chrome_security_state_model_client.h

Issue 2410043003: Add a console messsage for HTTP-bad (Closed)
Patch Set: de-const other WebContentsDelegates Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ssl/chrome_security_state_model_client.h
diff --git a/chrome/browser/ssl/chrome_security_state_model_client.h b/chrome/browser/ssl/chrome_security_state_model_client.h
index c5f8854fa5cb259bdbd8340acb1b8bdcd77a3bd5..be12ac1b9c20d71addcecb9aef70b68d4a101abb 100644
--- a/chrome/browser/ssl/chrome_security_state_model_client.h
+++ b/chrome/browser/ssl/chrome_security_state_model_client.h
@@ -10,11 +10,13 @@
#include "base/macros.h"
#include "components/security_state/security_state_model.h"
#include "components/security_state/security_state_model_client.h"
+#include "content/public/browser/web_contents_observer.h"
#include "content/public/browser/web_contents_user_data.h"
#include "third_party/WebKit/public/platform/WebSecurityStyle.h"
namespace content {
struct SecurityStyleExplanations;
+class NavigationHandle;
class WebContents;
} // namespace content
@@ -22,6 +24,7 @@ class WebContents;
// information that it needs to determine the page's security status.
class ChromeSecurityStateModelClient
: public security_state::SecurityStateModelClient,
+ public content::WebContentsObserver,
public content::WebContentsUserData<ChromeSecurityStateModelClient> {
public:
~ChromeSecurityStateModelClient() override;
@@ -29,6 +32,13 @@ class ChromeSecurityStateModelClient
void GetSecurityInfo(
security_state::SecurityStateModel::SecurityInfo* result) const;
+ // Called when the NavigationEntry's SSLStatus changes.
+ void VisibleSSLStateChanged();
+
+ // content::WebContentsObserver:
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override;
+
// Returns the SecurityStyle that should be applied to a WebContents
// with the given |security_info|. Populates
// |security_style_explanations| to explain why the returned
@@ -50,6 +60,12 @@ class ChromeSecurityStateModelClient
content::WebContents* web_contents_;
std::unique_ptr<security_state::SecurityStateModel> security_state_model_;
+ // True if a console has been logged about an omnibox warning that
+ // will be shown in future versions of Chrome for insecure HTTP
+ // pages. This message should only be logged once per main-frame
+ // navigation.
+ bool logged_http_warning_on_current_navigation_;
+
DISALLOW_COPY_AND_ASSIGN(ChromeSecurityStateModelClient);
};
« no previous file with comments | « no previous file | chrome/browser/ssl/chrome_security_state_model_client.cc » ('j') | chrome/browser/ui/browser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698