Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 241003002: Change IS_UNDEFINED to perform value comparison instead on typeof check. (Closed)

Created:
6 years, 8 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev
Visibility:
Public.

Description

Change IS_UNDEFINED to perform value comparison instead on typeof check. This makes our builtins immune to bug v8:3264. R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
PTAL
6 years, 8 months ago (2014-04-17 13:31:30 UTC) #1
rossberg
lgtm
6 years, 8 months ago (2014-04-17 13:41:54 UTC) #2
Dmitry Lomov (no reviews)
6 years, 8 months ago (2014-04-17 13:55:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698