Add unit test for notifying WebContents when SSLStatus changes due to HTTP-bad

content/browser/ssl/ssl_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/ssl/ssl_manager.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/macros.h"
@@ skipping 353 matching lines @@
   if (!entry)
     return;
 
   SSLStatus original_ssl_status = entry->GetSSL();  // Copy!
   entry->GetSSL().initialized = true;
   entry->GetSSL().content_status |= additional_content_status_flags;
 
   SiteInstance* site_instance = entry->site_instance();
   // Note that |site_instance| can be NULL here because NavigationEntries don't
   // necessarily have site instances.  Without a process, the entry can't
-  // possibly have insecure content.  See bug http://crbug.com/12423.
-  if (site_instance && ssl_host_state_delegate_ &&
-      ssl_host_state_delegate_->DidHostRunInsecureContent(
-          entry->GetURL().host(), site_instance->GetProcess()->GetID(),
-          SSLHostStateDelegate::MIXED_CONTENT)) {
-    entry->GetSSL().content_status |= SSLStatus::RAN_INSECURE_CONTENT;
-  }
+  // possibly have insecure content.  See bug https://crbug.com/12423.

[nasko, 2016/10/12 23:45:53]

Nice!

+  if (site_instance && ssl_host_state_delegate_) {
+    std::string host = entry->GetURL().host();
+    int process_id = site_instance->GetProcess()->GetID();
+    if (ssl_host_state_delegate_->DidHostRunInsecureContent(
+            host, process_id, SSLHostStateDelegate::MIXED_CONTENT)) {
+      entry->GetSSL().content_status |= SSLStatus::RAN_INSECURE_CONTENT;
+    }
 
-  // Only record information about subresources with cert errors if the
-  // main page is HTTPS with a certificate.
-  if (entry->GetURL().SchemeIsCryptographic() && entry->GetSSL().certificate &&
-      site_instance && ssl_host_state_delegate_ &&
-      ssl_host_state_delegate_->DidHostRunInsecureContent(
-          entry->GetURL().host(), site_instance->GetProcess()->GetID(),
-          SSLHostStateDelegate::CERT_ERRORS_CONTENT)) {
-    entry->GetSSL().content_status |= SSLStatus::RAN_CONTENT_WITH_CERT_ERRORS;
+    // Only record information about subresources with cert errors if the
+    // main page is HTTPS with a certificate.
+    if (entry->GetURL().SchemeIsCryptographic() &&
+        entry->GetSSL().certificate &&
+        ssl_host_state_delegate_->DidHostRunInsecureContent(
+            host, process_id, SSLHostStateDelegate::CERT_ERRORS_CONTENT)) {
+      entry->GetSSL().content_status |= SSLStatus::RAN_CONTENT_WITH_CERT_ERRORS;
+    }
   }
 
   if (!entry->GetSSL().Equals(original_ssl_status))
     NotifyDidChangeVisibleSSLState();
 }
 
 void SSLManager::UpdateLastCommittedEntry(int additional_content_status_flags) {
   NavigationEntryImpl* entry = controller_->GetLastCommittedEntry();
   if (!entry)
     return;
@@ skipping 11 matching lines @@
   SSLManagerSet* managers =
       static_cast<SSLManagerSet*>(context->GetUserData(kSSLManagerKeyName));
 
   for (std::set<SSLManager*>::iterator i = managers->get().begin();
        i != managers->get().end(); ++i) {
     (*i)->UpdateEntry((*i)->controller()->GetLastCommittedEntry(), 0);
   }
 }
 
 }  // namespace content