Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2410003002: [modules] Add internal printer method for JSModuleNamespace. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Add internal printer method for JSModuleNamespace. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/a78afeb6cd9da579b2fbaa641bf44dee1bd7a345 Cr-Commit-Position: refs/heads/master@{#40181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
neis
4 years, 2 months ago (2016-10-11 09:25:31 UTC) #1
adamk
lgtm
4 years, 2 months ago (2016-10-11 15:54:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2410003002/1
4 years, 2 months ago (2016-10-11 15:55:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 16:28:57 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 16:29:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a78afeb6cd9da579b2fbaa641bf44dee1bd7a345
Cr-Commit-Position: refs/heads/master@{#40181}

Powered by Google App Engine
This is Rietveld 408576698