Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2409993005: Rename --input-gtest-json flag to --input-json flag (Closed)

Created:
4 years, 2 months ago by nednguyen
Modified:
4 years, 2 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Rename --input-gtest-json flag to --input-json flag This is for generalizing the logic of uploading test results to support other format such as JSON Test Result format. BUG=655520, 649762 Committed: https://chromium.googlesource.com/chromium/tools/build/+/1a9df62478f43484695e00ed6a808673461c5736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M scripts/slave/recipe_modules/test_results/resources/upload_test_results.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
nednguyen
4 years, 2 months ago (2016-10-13 10:17:03 UTC) #2
nednguyen
PTAL. This CL should fix https://bugs.chromium.org/p/chromium/issues/detail?id=655520
4 years, 2 months ago (2016-10-13 10:20:39 UTC) #4
Sergiy Byelozyorov
lgtm
4 years, 2 months ago (2016-10-13 10:31:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409993005/1
4 years, 2 months ago (2016-10-13 10:32:21 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 10:36:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/1a9df62478f43484695e...

Powered by Google App Engine
This is Rietveld 408576698