Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Issue 2409963003: Don't let WebView crash on copy-paste (Closed)

Created:
4 years, 2 months ago by Nate Fischer
Modified:
4 years, 2 months ago
Reviewers:
Theresa
CC:
agrieve+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't let WebView crash on copy-paste WebView would previously crash on copy-paste for certain devices. This more carefully handles exceptions when getting ClipData.Items. BUG=654802 Committed: https://crrev.com/6f3cda16c5ecca60d4eed94f094266baccfb9ed7 Cr-Commit-Position: refs/heads/master@{#425064}

Patch Set 1 #

Patch Set 2 : Adding comments #

Total comments: 1

Patch Set 3 : Catch generic Exception #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M ui/android/java/src/org/chromium/ui/base/Clipboard.java View 1 2 2 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Nate Fischer
Theresa, let me know if you'll be able to take a look at this. Although ...
4 years, 2 months ago (2016-10-12 17:10:58 UTC) #3
Theresa
https://codereview.chromium.org/2409963003/diff/20001/ui/android/java/src/org/chromium/ui/base/Clipboard.java File ui/android/java/src/org/chromium/ui/base/Clipboard.java (right): https://codereview.chromium.org/2409963003/diff/20001/ui/android/java/src/org/chromium/ui/base/Clipboard.java#newcode94 ui/android/java/src/org/chromium/ui/base/Clipboard.java:94: } catch (RuntimeException e) { Will it always be ...
4 years, 2 months ago (2016-10-12 17:39:34 UTC) #4
Nate Fischer
On 2016/10/12 at 17:39:34, twellington wrote: > https://codereview.chromium.org/2409963003/diff/20001/ui/android/java/src/org/chromium/ui/base/Clipboard.java > File ui/android/java/src/org/chromium/ui/base/Clipboard.java (right): > > https://codereview.chromium.org/2409963003/diff/20001/ui/android/java/src/org/chromium/ui/base/Clipboard.java#newcode94 ...
4 years, 2 months ago (2016-10-13 00:21:44 UTC) #5
Theresa
On 2016/10/13 00:21:44, Nate Fischer wrote: > On 2016/10/12 at 17:39:34, twellington wrote: > > ...
4 years, 2 months ago (2016-10-13 00:24:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409963003/40001
4 years, 2 months ago (2016-10-13 16:26:29 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-13 16:57:09 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 17:00:02 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6f3cda16c5ecca60d4eed94f094266baccfb9ed7
Cr-Commit-Position: refs/heads/master@{#425064}

Powered by Google App Engine
This is Rietveld 408576698