Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 2409953005: X87: [stubs] Refactor the CallICStub to pass the number of arguments. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [stubs] Refactor the CallICStub to pass the number of arguments. port c15c58274f04eef9d62245f33a836cd8287b9c53 (r40206) original commit message: This is the next step to unify the Call/Construct feedback collection and prepare it to be able to collect SharedFunctionInfo feedback. This also reduces the CallICStub overhead quite a bit since we only need one stub per mode (and tail call mode), not also one per call arity. BUG= Committed: https://crrev.com/232bbb1be2875e18f8cacef9d3f7bdda32576b6c Cr-Commit-Position: refs/heads/master@{#40244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 9 chunks +15 lines, -5 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-13 01:52:44 UTC) #2
Weiliang
lgtm
4 years, 2 months ago (2016-10-13 06:41:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409953005/1
4 years, 2 months ago (2016-10-13 06:47:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-13 07:10:34 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-13 07:11:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/232bbb1be2875e18f8cacef9d3f7bdda32576b6c
Cr-Commit-Position: refs/heads/master@{#40244}

Powered by Google App Engine
This is Rietveld 408576698