Milo: Display pending builds

Milo: Display pending builds

This fixes some bugs (naming mismatches) with the receiving end of pubsub, and
also adds pending build data into a builder view.

The rename was done here:
https://codereview.chromium.org/2406133002/

BUG=654623
Committed: https://github.com/luci/luci-go/commit/ab30d82eb01708c79fec5db8833523af53d8169e

[Ryan Tseng, 2016-10-11 04:17:58]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 04:18:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-10-11 04:19:06]

Description was changed from

==========
Milo: Display pending builds

This fixes some bugs (naming mismatches) with the receiving end of pubsub, and
also adds pending build data into a builder view.

BUG=654623
==========

to

==========
Milo: Display pending builds

This fixes some bugs (naming mismatches) with the receiving end of pubsub, and
also adds pending build data into a builder view.

The rename was done here:
https://codereview.chromium.org/2406133002/

BUG=654623
==========

[hinoka, 2016-10-11 04:19:06]

hinoka@chromium.org changed reviewers:
+ estaab@chromium.org, martiniss@chromium.org

[hinoka, 2016-10-11 04:19:25]

hinoka@chromium.org changed reviewers:
+ hinoka@chromium.org

[hinoka, 2016-10-11 04:19:25]

ptal

[commit-bot: I haz the power, 2016-10-11 04:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 04:26:39]

Dry run: This issue passed the CQ dry run.

[estaab, 2016-10-11 16:16:27]

lgtm

https://codereview.chromium.org/2409953002/diff/1/milo/appengine/buildbot/bui...
File milo/appengine/buildbot/builder.go (right):

https://codereview.chromium.org/2409953002/diff/1/milo/appengine/buildbot/bui...
milo/appengine/buildbot/builder.go:173: /* TODO(hinoka): This works, but there's
a lot of junk data from
How about uncommenting so we can see the debug output, but don't set
result.CurrentBuilds at the end?

Otherwise we shouldn't be checking in commented out code.

[Ryan Tseng, 2016-10-12 02:07:34]

Review

[Ryan Tseng, 2016-10-12 02:07:35]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 02:07:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hinoka, 2016-10-12 02:09:20]

https://codereview.chromium.org/2409953002/diff/1/milo/appengine/buildbot/bui...
File milo/appengine/buildbot/builder.go (right):

https://codereview.chromium.org/2409953002/diff/1/milo/appengine/buildbot/bui...
milo/appengine/buildbot/builder.go:173: /* TODO(hinoka): This works, but there's
a lot of junk data from
On 2016/10/11 16:16:27, estaab wrote:
> How about uncommenting so we can see the debug output, but don't set
> result.CurrentBuilds at the end?
> 
> Otherwise we shouldn't be checking in commented out code.

Done.

[hinoka, 2016-10-12 02:09:24]

The CQ bit was unchecked by hinoka@chromium.org

[hinoka, 2016-10-12 02:14:55]

The CQ bit was checked by hinoka@chromium.org

[hinoka, 2016-10-12 02:14:55]

The patchset sent to the CQ was uploaded after l-g-t-m from estaab@chromium.org
Link to the patchset: https://codereview.chromium.org/2409953002/#ps20001
(title: "Review")

[commit-bot: I haz the power, 2016-10-12 02:15:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 02:18:49]

Description was changed from

==========
Milo: Display pending builds

This fixes some bugs (naming mismatches) with the receiving end of pubsub, and
also adds pending build data into a builder view.

The rename was done here:
https://codereview.chromium.org/2406133002/

BUG=654623
==========

to

==========
Milo: Display pending builds

This fixes some bugs (naming mismatches) with the receiving end of pubsub, and
also adds pending build data into a builder view.

The rename was done here:
https://codereview.chromium.org/2406133002/

BUG=654623

Committed:
https://github.com/luci/luci-go/commit/ab30d82eb01708c79fec5db8833523af53d8169e
==========

[commit-bot: I haz the power, 2016-10-12 02:18:50]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/ab30d82eb01708c79fec5db8833523af53d8169e