Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: Source/modules/device_orientation/DeviceMotionController.cpp

Issue 240993003: Fix the issue with adding/removing event listeners for Device Motion/Orientation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: added fix and test for device orientation Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright 2010 Apple Inc. All rights reserved. 2 * Copyright 2010 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 3 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above copyright 10 * * Redistributions in binary form must reproduce the above copyright
11 * notice, this list of conditions and the following disclaimer in the 11 * notice, this list of conditions and the following disclaimer in the
12 * documentation and/or other materials provided with the distribution. 12 * documentation and/or other materials provided with the distribution.
13 * 13 *
14 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY 14 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS ``AS IS'' AND ANY
15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 15 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 16 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR 17 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 18 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 19 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 20 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 21 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 22 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 23 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 24 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
25 */ 25 */
26 26
27 #include "config.h" 27 #include "config.h"
28 #include "modules/device_orientation/DeviceMotionController.h" 28 #include "modules/device_orientation/DeviceMotionController.h"
29 29
30 #include "RuntimeEnabledFeatures.h"
31 #include "core/dom/Document.h" 30 #include "core/dom/Document.h"
31 #include "core/frame/DOMWindow.h"
32 #include "core/page/Page.h" 32 #include "core/page/Page.h"
33 #include "modules/device_orientation/DeviceMotionData.h" 33 #include "modules/device_orientation/DeviceMotionData.h"
34 #include "modules/device_orientation/DeviceMotionDispatcher.h" 34 #include "modules/device_orientation/DeviceMotionDispatcher.h"
35 #include "modules/device_orientation/DeviceMotionEvent.h" 35 #include "modules/device_orientation/DeviceMotionEvent.h"
36 36
37 namespace WebCore { 37 namespace WebCore {
38 38
39 DeviceMotionController::DeviceMotionController(Document& document) 39 DeviceMotionController::DeviceMotionController(Document& document)
40 : DeviceSensorEventController(document) 40 : DeviceSensorEventController(document)
41 , DOMWindowLifecycleObserver(document.domWindow()) 41 , DOMWindowLifecycleObserver(document.domWindow())
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 { 86 {
87 DeviceMotionDispatcher::instance().removeDeviceMotionController(this); 87 DeviceMotionDispatcher::instance().removeDeviceMotionController(this);
88 } 88 }
89 89
90 bool DeviceMotionController::isNullEvent(Event* event) 90 bool DeviceMotionController::isNullEvent(Event* event)
91 { 91 {
92 DeviceMotionEvent* motionEvent = toDeviceMotionEvent(event); 92 DeviceMotionEvent* motionEvent = toDeviceMotionEvent(event);
93 return !motionEvent->deviceMotionData()->canProvideEventData(); 93 return !motionEvent->deviceMotionData()->canProvideEventData();
94 } 94 }
95 95
96 void DeviceMotionController::didAddEventListener(DOMWindow*, const AtomicString& eventType) 96 void DeviceMotionController::didAddEventListener(DOMWindow* window, const Atomic String& eventType)
97 { 97 {
98 if (eventType == EventTypeNames::devicemotion && RuntimeEnabledFeatures::dev iceMotionEnabled()) { 98 if (eventType != EventTypeNames::devicemotion)
99 if (page() && page()->visibilityState() == PageVisibilityStateVisible) 99 return;
100 startUpdating(); 100
101 m_hasEventListener = true; 101 if (page() && page()->visibilityState() == PageVisibilityStateVisible)
102 } 102 startUpdating();
103
104 m_hasEventListener = true;
103 } 105 }
104 106
105 void DeviceMotionController::didRemoveEventListener(DOMWindow*, const AtomicStri ng& eventType) 107 void DeviceMotionController::didRemoveEventListener(DOMWindow* window, const Ato micString& eventType)
106 { 108 {
107 if (eventType == EventTypeNames::devicemotion) { 109 if (eventType != EventTypeNames::devicemotion || window->hasEventListeners(E ventTypeNames::devicemotion))
108 stopUpdating(); 110 return;
109 m_hasEventListener = false; 111
110 } 112 stopUpdating();
113 m_hasEventListener = false;
111 } 114 }
112 115
113 void DeviceMotionController::didRemoveAllEventListeners(DOMWindow*) 116 void DeviceMotionController::didRemoveAllEventListeners(DOMWindow*)
114 { 117 {
115 stopUpdating(); 118 stopUpdating();
116 m_hasEventListener = false; 119 m_hasEventListener = false;
117 } 120 }
118 121
119 } // namespace WebCore 122 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698