LayoutTests/fast/dom/DeviceMotion/multiple-event-listeners.html - Issue 240993003: Fix the issue with adding/removing event listeners for Device Motion/Orientation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/DeviceMotion/multiple-event-listeners.html

Issue 240993003: Fix the issue with adding/removing event listeners for Device Motion/Orientation. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: similarity=80 Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | LayoutTests/fast/dom/DeviceMotion/multiple-event-listeners-expected.txt » ('j') | LayoutTests/fast/dom/DeviceMotion/script-tests/multiple-event-listeners.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="../../../resources/js-test.js"></script>

	4 </head>

	5 <body>

	6 <script src="script-tests/multiple-event-listeners.js"></script>
	Inactive 2014/04/17 14:39:33 I think it is frown upon to have the test in a sep I think it is frown upon to have the test in a separate js file these days. We prefer to inline them in the html when possible. Peter Beverloo 2014/04/17 14:48:17 +1 Show quoted text On 2014/04/17 14:39:33, Chris Dumez wrote: > I think it is frown upon to have the test in a separate js file these days. We > prefer to inline them in the html when possible. +1 timvolodine 2014/04/17 15:34:13 Done. Show quoted text On 2014/04/17 14:39:33, Chris Dumez wrote: > I think it is frown upon to have the test in a separate js file these days. We > prefer to inline them in the html when possible. Done. timvolodine 2014/04/17 15:34:13 Done. Show quoted text On 2014/04/17 14:48:17, Peter Beverloo wrote: > On 2014/04/17 14:39:33, Chris Dumez wrote: > > I think it is frown upon to have the test in a separate js file these days. We > > prefer to inline them in the html when possible. > > +1 Done.
	7 </body>

	8 </html>

OLD	NEW