Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2232)

Unified Diff: cc/scheduler/scheduler.h

Issue 2409923002: cc: Rename SwapBuffers on CompositorFrameSink to SubmitCompositorFrame (Closed)
Patch Set: swap-to-submit: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/scheduler/compositor_timing_history.cc ('k') | cc/scheduler/scheduler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/scheduler/scheduler.h
diff --git a/cc/scheduler/scheduler.h b/cc/scheduler/scheduler.h
index 235a4f8e4e2974d816eea81d1d294cdae1968cfc..856e212b4375c522d192095d9a283120f69f2dbc 100644
--- a/cc/scheduler/scheduler.h
+++ b/cc/scheduler/scheduler.h
@@ -38,8 +38,8 @@ class SchedulerClient {
virtual void WillBeginImplFrame(const BeginFrameArgs& args) = 0;
virtual void ScheduledActionSendBeginMainFrame(
const BeginFrameArgs& args) = 0;
- virtual DrawResult ScheduledActionDrawAndSwapIfPossible() = 0;
- virtual DrawResult ScheduledActionDrawAndSwapForced() = 0;
+ virtual DrawResult ScheduledActionDrawIfPossible() = 0;
+ virtual DrawResult ScheduledActionDrawForced() = 0;
virtual void ScheduledActionCommit() = 0;
virtual void ScheduledActionActivateSyncTree() = 0;
virtual void ScheduledActionBeginCompositorFrameSinkCreation() = 0;
@@ -89,8 +89,12 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
void SetNeedsPrepareTiles();
- void DidSwapBuffers();
- void DidSwapBuffersComplete();
+ // Drawing should result in submitting a CompositorFrame to the
+ // CompositorFrameSink and then calling this.
+ void DidSubmitCompositorFrame();
+ // The CompositorFrameSink acks when it is ready for a new frame which
+ // should result in this getting called to unblock the next draw.
+ void DidReceiveCompositorFrameAck();
void SetTreePrioritiesAndScrollState(TreePriority tree_priority,
ScrollHandlerState scroll_handler_state);
@@ -174,8 +178,8 @@ class CC_EXPORT Scheduler : public BeginFrameObserverBase {
void ScheduleBeginImplFrameDeadlineIfNeeded();
void BeginImplFrameNotExpectedSoon();
void SetupNextBeginFrameIfNeeded();
- void DrawAndSwapIfPossible();
- void DrawAndSwapForced();
+ void DrawIfPossible();
+ void DrawForced();
void ProcessScheduledActions();
void UpdateCompositorTimingHistoryRecordingEnabled();
bool ShouldRecoverMainLatency(const BeginFrameArgs& args,
« no previous file with comments | « cc/scheduler/compositor_timing_history.cc ('k') | cc/scheduler/scheduler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698