Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: components/safe_browsing_db/v4_store_unittest.cc

Issue 2409793002: Add detailed UMA metrics for v4_store, broken down by storeid. (Closed)
Patch Set: Mark old histograms as obsolete instead of deleting them Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_store_unittest.cc
diff --git a/components/safe_browsing_db/v4_store_unittest.cc b/components/safe_browsing_db/v4_store_unittest.cc
index 28191dad4c78179bb345c843134ec17d18fa9e55..c3824c858675a78fd6716f8b3a2759787ab78a50 100644
--- a/components/safe_browsing_db/v4_store_unittest.cc
+++ b/components/safe_browsing_db/v4_store_unittest.cc
@@ -711,7 +711,8 @@ TEST_F(V4StoreTest, TestAdditionsWithRiceEncodingFailsWithInvalidInput) {
HashPrefixMap additions_map;
EXPECT_EQ(RICE_DECODING_FAILURE,
V4Store(task_runner_, store_path_)
- .UpdateHashPrefixMapFromAdditions(additions, &additions_map));
+ .UpdateHashPrefixMapFromAdditions("V4Metric", additions,
+ &additions_map));
}
#endif
@@ -732,7 +733,8 @@ TEST_F(V4StoreTest, TestAdditionsWithRiceEncodingSucceeds) {
HashPrefixMap additions_map;
EXPECT_EQ(APPLY_UPDATE_SUCCESS,
V4Store(task_runner_, store_path_)
- .UpdateHashPrefixMapFromAdditions(additions, &additions_map));
+ .UpdateHashPrefixMapFromAdditions("V4Metric", additions,
+ &additions_map));
EXPECT_EQ(1u, additions_map.size());
EXPECT_EQ(std::string("\x5\0\0\0\fL\x93\xADV\x7F\xF6o\xCEo1\x81", 16),
additions_map[4]);

Powered by Google App Engine
This is Rietveld 408576698