Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

Behavior matches Firefox, Safari and Edge.

BUG=651762
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex

Committed: https://crrev.com/f05bfb57df525b7ed96d7d099b50d4693139fc62
Cr-Commit-Position: refs/heads/master@{#424562}

[rwlbuis, 2016-10-10 19:43:44]

Description was changed from

==========
sectionRowIndex WIP

BUG=
==========

to

==========
sectionRowIndex WIP

BUG=651762
==========

[rwlbuis, 2016-10-10 20:28:10]

Description was changed from

==========
sectionRowIndex WIP

BUG=651762
==========

to

==========
Do a more strict parent check in sectionRowIndex

Do a more strict parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1 [1].

BUG=651762

[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

[rwlbuis, 2016-10-10 20:28:18]

Description was changed from

==========
Do a more strict parent check in sectionRowIndex

Do a more strict parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1 [1].

BUG=651762

[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

to

==========
Do a more strict parent check in sectionRowIndex

Do a more strict parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1 [1].

BUG=651762


[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

[rwlbuis, 2016-10-10 20:28:31]

Description was changed from

==========
Do a more strict parent check in sectionRowIndex

Do a more strict parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1 [1].

BUG=651762


[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

to

==========
Do a more strict parent check in sectionRowIndex

Do a more strict parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1 [1].

BUG=651762

[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

[rwlbuis, 2016-10-10 20:28:57]

Description was changed from

==========
Do a more strict parent check in sectionRowIndex

Do a more strict parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1 [1].

BUG=651762

[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

to

==========
Do a more strict parent check in sectionRowIndex

Do a more strict parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1 [1].

BUG=651762
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

[rwlbuis, 2016-10-10 20:30:38]

Description was changed from

==========
Do a more strict parent check in sectionRowIndex

Do a more strict parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1 [1].

BUG=651762
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

to

==========
Implement a strict parent check in sectionRowIndex

Implement a strict parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

BUG=651762
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

[rwlbuis, 2016-10-10 20:31:13]

Description was changed from

==========
Implement a strict parent check in sectionRowIndex

Implement a strict parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

BUG=651762
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

to

==========
Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

BUG=651762
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

[rwlbuis, 2016-10-10 20:31:58]

rob.buis@samsung.com changed reviewers:
+ foolip@chromium.org, philipj@opera.com

[rwlbuis, 2016-10-10 20:31:59]

PTAL.

[foolip, 2016-10-11 09:28:44]

foolip@chromium.org changed reviewers:
- philipj@opera.com

[foolip, 2016-10-11 09:28:45]

LGTM if Edge and Firefox already pass the test, if not we might need to think
about whether the spec makes sense.

https://codereview.chromium.org/2409773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp (right):

https://codereview.chromium.org/2409773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp:87: ++rIndex;
Does this counting match exactly what the spec says, with the rows collection?
HTMLTableRowsCollection::rowAfter is pretty complicated, suggesting not. Can you
file an issue for this?

[rwlbuis, 2016-10-11 16:54:49]

https://codereview.chromium.org/2409773002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp (right):

https://codereview.chromium.org/2409773002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLTableRowElement.cpp:87: ++rIndex;
On 2016/10/11 09:28:45, foolip wrote:
> Does this counting match exactly what the spec says, with the rows collection?
> HTMLTableRowsCollection::rowAfter is pretty complicated, suggesting not. Can
you
> file an issue for this?

Yes, implementation seems pretty/too simple atm, filed crbug.com/654777.

[rwlbuis, 2016-10-11 16:58:37]

On 2016/10/11 09:28:45, foolip wrote:
> LGTM if Edge and Firefox already pass the test, if not we might need to think
> about whether the spec makes sense.

The subtests that are fixed by this change are also passing in Firefox nightly
and Edge.
Strangely enough, those two implementations fail the following cases:
Row in script-created table
Row in script-created nested table

Since we were already passing those before this change, I think the change is ok
since all it does is fix three subtests that are also passing in Firefox, Edge
and Safari.

[rwlbuis, 2016-10-11 16:59:06]

Description was changed from

==========
Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

BUG=651762
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

to

==========
Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

BUG=651762

Behavior matches Firefox, Safari and Edge.
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

[rwlbuis, 2016-10-11 17:50:15]

Description was changed from

==========
Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

BUG=651762

Behavior matches Firefox, Safari and Edge.
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

to

==========
Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

Behavior matches Firefox, Safari and Edge.

BUG=651762
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

[foolip, 2016-10-11 18:19:45]

On 2016/10/11 16:58:37, rwlbuis wrote:
> On 2016/10/11 09:28:45, foolip wrote:
> > LGTM if Edge and Firefox already pass the test, if not we might need to
think
> > about whether the spec makes sense.
> 
> The subtests that are fixed by this change are also passing in Firefox nightly
> and Edge.
> Strangely enough, those two implementations fail the following cases:
> Row in script-created table
> Row in script-created nested table
> 
> Since we were already passing those before this change, I think the change is
ok
> since all it does is fix three subtests that are also passing in Firefox, Edge
> and Safari.

Thanks for checking, still LGTM.

[rwlbuis, 2016-10-11 18:40:57]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2016-10-11 18:41:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 21:57:47]

Description was changed from

==========
Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

Behavior matches Firefox, Safari and Edge.

BUG=651762
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

to

==========
Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

Behavior matches Firefox, Safari and Edge.

BUG=651762
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

[commit-bot: I haz the power, 2016-10-11 21:57:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-11 22:02:03]

Description was changed from

==========
Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

Behavior matches Firefox, Safari and Edge.

BUG=651762
 
[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex
==========

to

==========
Implement a parent check in sectionRowIndex

Implement a parent check in sectionRowIndex [1], the parent
of the table row has to be a table or a section element, if not
we need to return -1.

Behavior matches Firefox, Safari and Edge.

BUG=651762

[1] https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex

Committed: https://crrev.com/f05bfb57df525b7ed96d7d099b50d4693139fc62
Cr-Commit-Position: refs/heads/master@{#424562}
==========

[commit-bot: I haz the power, 2016-10-11 22:02:04]

Patchset 1 (id:??) landed as
https://crrev.com/f05bfb57df525b7ed96d7d099b50d4693139fc62
Cr-Commit-Position: refs/heads/master@{#424562}