Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/skp/webpages_playback.py

Issue 2409753002: More fixes for webpages_playback (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/skp/webpages_playback.py
diff --git a/tools/skp/webpages_playback.py b/tools/skp/webpages_playback.py
index 67bb198e50d1f683168bfc97e2eeb5f96873982b..1320a8614c5a63065a11cb67147d887a572874c4 100644
--- a/tools/skp/webpages_playback.py
+++ b/tools/skp/webpages_playback.py
@@ -102,7 +102,7 @@ RETRY_RECORD_WPR_COUNT = 5
RETRY_RUN_MEASUREMENT_COUNT = 5
# Location of the credentials.json file in Google Storage.
-CREDENTIALS_GS_PATH = '/playback/credentials/credentials.json'
+CREDENTIALS_GS_PATH = 'playback/credentials/credentials.json'
X11_DISPLAY = os.getenv('DISPLAY', ':0')
@@ -480,7 +480,7 @@ class GoogleStorageDataStore(DataStore):
'gsutil', 'ls', '/'.join((self._url, name))])
except subprocess.CalledProcessError:
return False
- if len(output.splitlines) != 1:
+ if len(output.splitlines()) != 1:
return False
return True
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698