Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1343)

Issue 2409743002: Fix force policy installation of the removed pref-installed extension (Closed)

Created:
4 years, 2 months ago by emaxx
Modified:
4 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix force policy installation of the removed pref-installed extension This fixes the issue with the extension not being force-installed through the admin policy when it was previously installed by the external preference and then manually removed by the user. BUG=651197 TEST=Unit test Committed: https://crrev.com/6699afb688a0c3b9d6eb85915bc475a3a3b46716 Cr-Commit-Position: refs/heads/master@{#424245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/extensions/pending_extension_manager.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
emaxx
Antony, PTAL.
4 years, 2 months ago (2016-10-10 19:17:01 UTC) #4
asargent_no_longer_on_chrome
lgtm
4 years, 2 months ago (2016-10-10 20:01:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409743002/1
4 years, 2 months ago (2016-10-10 21:16:39 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-10 21:22:38 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 21:24:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6699afb688a0c3b9d6eb85915bc475a3a3b46716
Cr-Commit-Position: refs/heads/master@{#424245}

Powered by Google App Engine
This is Rietveld 408576698