Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 240973002: Harden DefineOrRedefineDataProperty. (Closed)

Created:
6 years, 8 months ago by ulan
Modified:
6 years, 8 months ago
CC:
v8-dev, Jakob Kummerow
Visibility:
Public.

Description

Harden DefineOrRedefineDataProperty. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20908

Patch Set 1 #

Patch Set 2 : return undefined to match v8natives.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/runtime.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
Michael, PTAL. Jakob this is FYI.
6 years, 8 months ago (2014-04-17 12:20:20 UTC) #1
Jakob Kummerow
lgtm
6 years, 8 months ago (2014-04-17 13:27:16 UTC) #2
ulan
6 years, 8 months ago (2014-04-23 12:28:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20908 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698