Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2409723002: Remove chrome.test.runWithNativesEnabled (Closed)

Created:
4 years, 2 months ago by Devlin
Modified:
4 years, 2 months ago
Reviewers:
lazyboy, hirono
CC:
chromium-reviews, extensions-reviews_chromium.org, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, fukino+watch_chromium.org, chromium-apps-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove chrome.test.runWithNativesEnabled BUG=654511 BUG=629431 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/078b2e8c3809e52b823269c009e68f39541085f5 Cr-Commit-Position: refs/heads/master@{#424300}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -38 lines) Patch
M extensions/common/api/test.json View 1 chunk +0 lines, -12 lines 0 comments Download
M extensions/renderer/resources/test_custom_bindings.js View 2 chunks +0 lines, -5 lines 0 comments Download
M extensions/renderer/v8_context_native_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/renderer/v8_context_native_handler.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M extensions/test/data/api_test_base_unittest.js View 1 chunk +1 line, -2 lines 0 comments Download
M ui/file_manager/externs/chrome_test.js View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Devlin
another one for you, lazyboy@
4 years, 2 months ago (2016-10-10 20:21:08 UTC) #7
lazyboy
lgtm
4 years, 2 months ago (2016-10-10 20:31:35 UTC) #8
Devlin
+hirono@ for ui/file_manager.
4 years, 2 months ago (2016-10-10 20:39:06 UTC) #10
hirono
lgtm
4 years, 2 months ago (2016-10-11 00:01:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409723002/1
4 years, 2 months ago (2016-10-11 00:16:26 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 00:21:59 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 00:25:31 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/078b2e8c3809e52b823269c009e68f39541085f5
Cr-Commit-Position: refs/heads/master@{#424300}

Powered by Google App Engine
This is Rietveld 408576698