Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1423)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc

Issue 2409653003: [Merge to 2883] Revert "[scheduler] Throttle background frames with 1% CPU limit" (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
index f7ba68c71c706abc2f5cb8692294400ea498420e..08d9a41f6baa8b27845cbb14b3054ee27d56b56c 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
@@ -5,7 +5,6 @@
#include "platform/scheduler/renderer/web_view_scheduler_impl.h"
#include "base/logging.h"
-#include "platform/RuntimeEnabledFeatures.h"
#include "platform/scheduler/base/virtual_time_domain.h"
#include "platform/scheduler/child/scheduler_tqm_delegate.h"
#include "platform/scheduler/renderer/auto_advancing_virtual_time_domain.h"
@@ -16,12 +15,6 @@
namespace blink {
namespace scheduler {
-namespace {
-
-const double kBackgroundBudgetAsCPUFraction = .01;
-
-} // namespace
-
WebViewSchedulerImpl::WebViewSchedulerImpl(
WebScheduler::InterventionReporter* intervention_reporter,
RendererSchedulerImpl* renderer_scheduler,
@@ -35,23 +28,8 @@ WebViewSchedulerImpl::WebViewSchedulerImpl(
allow_virtual_time_to_advance_(true),
have_seen_loading_task_(false),
virtual_time_(false),
- is_audio_playing_(false),
- background_time_budget_pool_(nullptr) {
+ is_audio_playing_(false) {
renderer_scheduler->AddWebViewScheduler(this);
-
- if (RuntimeEnabledFeatures::expensiveBackgroundTimerThrottlingEnabled()) {
- background_time_budget_pool_ =
- renderer_scheduler_->task_queue_throttler()->CreateTimeBudgetPool(
- "background");
-
- LazyNow lazy_now(renderer_scheduler_->tick_clock());
-
- // Disable throttling because page is visible by default.
- background_time_budget_pool_->DisableThrottling(&lazy_now);
-
- background_time_budget_pool_->SetTimeBudget(lazy_now.Now(),
- kBackgroundBudgetAsCPUFraction);
- }
}
WebViewSchedulerImpl::~WebViewSchedulerImpl() {
@@ -61,9 +39,6 @@ WebViewSchedulerImpl::~WebViewSchedulerImpl() {
frame_scheduler->DetachFromWebViewScheduler();
}
renderer_scheduler_->RemoveWebViewScheduler(this);
-
- if (background_time_budget_pool_)
- background_time_budget_pool_->Close();
}
void WebViewSchedulerImpl::setPageVisible(bool page_visible) {
@@ -75,15 +50,6 @@ void WebViewSchedulerImpl::setPageVisible(bool page_visible) {
for (WebFrameSchedulerImpl* frame_scheduler : frame_schedulers_) {
frame_scheduler->setPageVisible(page_visible_);
}
-
- if (background_time_budget_pool_) {
- LazyNow lazy_now(renderer_scheduler_->tick_clock());
- if (page_visible_) {
- background_time_budget_pool_->DisableThrottling(&lazy_now);
- } else {
- background_time_budget_pool_->EnableThrottling(&lazy_now);
- }
- }
}
std::unique_ptr<WebFrameSchedulerImpl>

Powered by Google App Engine
This is Rietveld 408576698