Source/core/html/canvas/WebGLSharedObject.h - Issue 24096029: Moved the majority of WebGL functionality into WebGLRenderingContextBase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGLSharedObject.h

Issue 24096029: Moved the majority of WebGL functionality into WebGLRenderingContextBase (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fixed typo in gypi, was only causing issues on Windows (?!?) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/canvas/WebGLSharedObject.h

diff --git a/Source/core/html/canvas/WebGLSharedObject.h b/Source/core/html/canvas/WebGLSharedObject.h

index 025b960ed61413d37f6ad9c172fea83ba13d1a96..990c8ae1565949339baaf7b4b428c0e1a5c93a32 100644

--- a/Source/core/html/canvas/WebGLSharedObject.h

+++ b/Source/core/html/canvas/WebGLSharedObject.h

@@ -31,7 +31,7 @@

namespace WebCore {

class WebGLContextGroup;

-class WebGLRenderingContext;

+class WebGLRenderingContextBase;

// WebGLSharedObject the base class for objects that can be shared by multiple

// WebGLRenderingContexts.

@@ -47,7 +47,7 @@ public:

virtual bool isShader() const { return false; }

virtual bool isTexture() const { return false; }

- virtual bool validate(const WebGLContextGroup* contextGroup, const WebGLRenderingContext*) const OVERRIDE FINAL

+ virtual bool validate(const WebGLContextGroup* contextGroup, const WebGLRenderingContextBase*) const OVERRIDE FINAL

{

return contextGroup == m_contextGroup;

}

@@ -55,7 +55,7 @@ public:

void detachContextGroup();

protected:

- WebGLSharedObject(WebGLRenderingContext*);

+ WebGLSharedObject(WebGLRenderingContextBase*);

virtual bool hasGroupOrContext() const OVERRIDE FINAL

{