Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24096025: Simulate a mouse click. (Closed)

Created:
7 years, 3 months ago by weitao
Modified:
7 years, 2 months ago
Reviewers:
garykac
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@browser_tests_e2b
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : CR feedback. #

Patch Set 3 : Fixing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -0 lines) Patch
M remoting/test/me2me_browsertest.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M remoting/test/remote_desktop_browsertest.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M remoting/test/remote_desktop_browsertest.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
weitao
7 years, 3 months ago (2013-09-19 21:20:27 UTC) #1
garykac
https://codereview.chromium.org/24096025/diff/1/remoting/test/me2me_browsertest.cc File remoting/test/me2me_browsertest.cc (right): https://codereview.chromium.org/24096025/diff/1/remoting/test/me2me_browsertest.cc#newcode48 remoting/test/me2me_browsertest.cc:48: // Visually verifies that "Dash Home" is clicked on ...
7 years, 3 months ago (2013-09-19 21:37:26 UTC) #2
weitao
PTAL https://codereview.chromium.org/24096025/diff/1/remoting/test/me2me_browsertest.cc File remoting/test/me2me_browsertest.cc (right): https://codereview.chromium.org/24096025/diff/1/remoting/test/me2me_browsertest.cc#newcode48 remoting/test/me2me_browsertest.cc:48: // Visually verifies that "Dash Home" is clicked ...
7 years, 3 months ago (2013-09-19 22:04:56 UTC) #3
garykac
lgtm after the nits we discussed are fixed
7 years, 3 months ago (2013-09-23 21:58:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/24096025/15001
7 years, 3 months ago (2013-09-24 17:25:22 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=171203
7 years, 3 months ago (2013-09-24 18:06:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/24096025/15001
7 years, 3 months ago (2013-09-24 20:37:31 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=171500
7 years, 3 months ago (2013-09-25 02:09:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/24096025/15001
7 years, 2 months ago (2013-09-25 16:39:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weitaosu@chromium.org/24096025/15001
7 years, 2 months ago (2013-09-25 21:34:18 UTC) #10
commit-bot: I haz the power
7 years, 2 months ago (2013-09-26 03:27:12 UTC) #11
Message was sent while issue was closed. 
Change committed as 225305

Powered by Google App Engine
This is Rietveld 408576698