Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 24096017: Handlify JSObject::SetNormalizedProperty methods. (Closed)

Created:
7 years, 3 months ago by Michael Starzinger
Modified:
7 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Handlify JSObject::SetNormalizedProperty methods. R=yangguo@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16799

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments by Yang Guo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -298 lines) Patch
M src/objects.h View 7 chunks +36 lines, -37 lines 0 comments Download
M src/objects.cc View 1 37 chunks +226 lines, -256 lines 0 comments Download
M src/runtime.cc View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 3 months ago (2013-09-17 12:45:04 UTC) #1
Yang
lgtm. https://codereview.chromium.org/24096017/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/24096017/diff/1/src/objects.cc#newcode4113 src/objects.cc:4113: RETURN_IF_EMPTY_HANDLE_VALUE(isolate, result, Handle<Object>()); You could move this check ...
7 years, 3 months ago (2013-09-17 16:39:45 UTC) #2
Michael Starzinger
Thanks for the review. Addressed comments. Landing. https://codereview.chromium.org/24096017/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/24096017/diff/1/src/objects.cc#newcode4113 src/objects.cc:4113: RETURN_IF_EMPTY_HANDLE_VALUE(isolate, result, ...
7 years, 3 months ago (2013-09-18 16:19:55 UTC) #3
Michael Starzinger
7 years, 3 months ago (2013-09-18 16:26:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r16799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698