Add toRenderSVGResourceFilter() fuction, and use it.

Add toRenderSVGResourceFilter() fuction, and use it.

This function has type checking assertions for helping to find bad-cast bugs.
Besides this cl clean-up to use static_cast<RenderSVGResourceFilter*>.

BUG=N/A

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157736

[gyuyoung-inactive, 2013-09-11 23:23:19]

Add tkent.

[tkent, 2013-09-11 23:50:48]

https://codereview.chromium.org/24096014/diff/1/Source/core/rendering/svg/Ren...
File Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h (right):

https://codereview.chromium.org/24096014/diff/1/Source/core/rendering/svg/Ren...
Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h:56:
toRenderSVGFilter(filter)->primitiveAttributeChanged(this, attribute);
This is confusing.  We don't have 'RenderSVGFilter' class. toRenderSVGFilter
should be renamed to toRenderSVGResourceFilter.

[gyuyoung-inactive, 2013-09-11 23:54:08]

On 2013/09/11 23:50:48, tkent wrote:
>
https://codereview.chromium.org/24096014/diff/1/Source/core/rendering/svg/Ren...
> File Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h (right):
> 
>
https://codereview.chromium.org/24096014/diff/1/Source/core/rendering/svg/Ren...
> Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h:56:
> toRenderSVGFilter(filter)->primitiveAttributeChanged(this, attribute);
> This is confusing.  We don't have 'RenderSVGFilter' class. toRenderSVGFilter
> should be renamed to toRenderSVGResourceFilter.

I didn't want to modify existing function. But, I agree with your point. Patch
will be fixed.

[gyuyoung-inactive, 2013-09-12 03:22:09]

On 2013/09/11 23:54:08, gyuyoung wrote:
> On 2013/09/11 23:50:48, tkent wrote:
> >
>
https://codereview.chromium.org/24096014/diff/1/Source/core/rendering/svg/Ren...
> > File Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h (right):
> > 
> >
>
https://codereview.chromium.org/24096014/diff/1/Source/core/rendering/svg/Ren...
> > Source/core/rendering/svg/RenderSVGResourceFilterPrimitive.h:56:
> > toRenderSVGFilter(filter)->primitiveAttributeChanged(this, attribute);
> > This is confusing.  We don't have 'RenderSVGFilter' class. toRenderSVGFilter
> > should be renamed to toRenderSVGResourceFilter.
> 
> I didn't want to modify existing function. But, I agree with your point. Patch
> will be fixed.

Patch is updated. Please review again.

[tkent, 2013-09-12 03:30:46]

https://codereview.chromium.org/24096014/diff/6001/Source/core/rendering/svg/...
File Source/core/rendering/svg/RenderSVGResourceFilter.h (right):

https://codereview.chromium.org/24096014/diff/6001/Source/core/rendering/svg/...
Source/core/rendering/svg/RenderSVGResourceFilter.h:91: inline
RenderSVGResourceFilter* toRenderSVGResourceFilter(RenderSVGResource* resource)
We should have both of toRenderSVGResourceFilter(RenderObject*) and
toRenderSVGResourceFilter(RenderSVGResource*).

[gyuyoung-inactive, 2013-09-12 03:54:07]

On 2013/09/12 03:30:46, tkent wrote:
>
https://codereview.chromium.org/24096014/diff/6001/Source/core/rendering/svg/...
> File Source/core/rendering/svg/RenderSVGResourceFilter.h (right):
> 
>
https://codereview.chromium.org/24096014/diff/6001/Source/core/rendering/svg/...
> Source/core/rendering/svg/RenderSVGResourceFilter.h:91: inline
> RenderSVGResourceFilter* toRenderSVGResourceFilter(RenderSVGResource*
resource)
> We should have both of toRenderSVGResourceFilter(RenderObject*) and
> toRenderSVGResourceFilter(RenderSVGResource*).

Ah, yes, I misunderstood what was your comment. Right. we need to keep it as
well.

[gyuyoung-inactive, 2013-09-13 01:52:00]

On 2013/09/12 03:54:07, gyuyoung wrote:
> On 2013/09/12 03:30:46, tkent wrote:
> >
>
https://codereview.chromium.org/24096014/diff/6001/Source/core/rendering/svg/...
> > File Source/core/rendering/svg/RenderSVGResourceFilter.h (right):
> > 
> >
>
https://codereview.chromium.org/24096014/diff/6001/Source/core/rendering/svg/...
> > Source/core/rendering/svg/RenderSVGResourceFilter.h:91: inline
> > RenderSVGResourceFilter* toRenderSVGResourceFilter(RenderSVGResource*
> resource)
> > We should have both of toRenderSVGResourceFilter(RenderObject*) and
> > toRenderSVGResourceFilter(RenderSVGResource*).
> 
> Ah, yes, I misunderstood what was your comment. Right. we need to keep it as
> well.

Kent, could you take a look this again ? Patch was updated.

[tkent, 2013-09-13 01:56:38]

lgtm

[commit-bot: I haz the power, 2013-09-13 01:58:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/24096014/12001

[commit-bot: I haz the power, 2013-09-13 02:38:37]

Retried try job too often on win_blink_rel for step(s) webkit_lint,
webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests,
wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-09-13 02:59:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/24096014/12001

[commit-bot: I haz the power, 2013-09-13 03:02:25]

Retried try job too often on win_blink_rel for step(s) webkit_lint,
webkit_python_tests, webkit_tests, webkit_unit_tests, weborigin_unittests,
wtf_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-09-13 03:39:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/24096014/12001

[commit-bot: I haz the power, 2013-09-13 04:59:33]

Change committed as 157736