Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2409593002: webpages_playback: Fix GS path with extra '/' (Closed)

Created:
4 years, 2 months ago by borenet2
Modified:
4 years, 2 months ago
Reviewers:
borenet, rmistry
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/skp/webpages_playback.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
borenet
4 years, 2 months ago (2016-10-10 14:38:48 UTC) #3
rmistry
lgtm
4 years, 2 months ago (2016-10-10 14:39:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409593002/1
4 years, 2 months ago (2016-10-10 14:39:44 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot on master.client.skia.android (JOB_FAILED, http://build.chromium.org/p/client.skia.android/builders/Test-Android-Clang-Nexus5-GPU-Adreno330-arm-Release-GN_Android-Trybot/builds/625)
4 years, 2 months ago (2016-10-10 14:55:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409593002/1
4 years, 2 months ago (2016-10-10 14:55:53 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 15:14:14 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1cebf7b4508ec8c6b258e7b0e53bed837c5676b2

Powered by Google App Engine
This is Rietveld 408576698