Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Unified Diff: ui/views/controls/button/md_text_button.cc

Issue 2409563002: views: use darker stroke for non-prominent buttons (Closed)
Patch Set: add an explanatory comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/button/md_text_button.cc
diff --git a/ui/views/controls/button/md_text_button.cc b/ui/views/controls/button/md_text_button.cc
index 9b3d05986a6469e9d7ec436c6575f13065149d8d..a097ed3977dde41f9c8ffe9598eec6dc4afa72f1 100644
--- a/ui/views/controls/button/md_text_button.cc
+++ b/ui/views/controls/button/md_text_button.cc
@@ -270,8 +270,13 @@ void MdTextButton::UpdateColors() {
bg_color = color_utils::GetResultingPaintColor(shade, bg_color);
}
+ // Specified text color: 5a5a5a @ 1.0 alpha
+ // Specified stroke color: 000000 @ 0.2 alpha
+ // 000000 @ 0.2 is very close to 5a5a5a @ 0.308 (== 0x4e); both are cccccc @
+ // 1.0, and this way if NativeTheme changes the button color, the button
+ // stroke will also change colors to match.
SkColor stroke_color =
- is_prominent_ ? SK_ColorTRANSPARENT : SkColorSetA(text_color, 0x33);
+ is_prominent_ ? SK_ColorTRANSPARENT : SkColorSetA(text_color, 0x4e);
DCHECK_EQ(SK_AlphaOPAQUE, static_cast<int>(SkColorGetA(bg_color)));
set_background(Background::CreateBackgroundPainter(
true, Painter::CreateRoundRectWith1PxBorderPainter(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698