Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2409553003: [heap] Remove dead write write barrier counter code (Closed)

Created:
4 years, 2 months ago by Michael Lippautz
Modified:
4 years, 2 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove dead write write barrier counter code R=ulan@chromium.org BUG= Committed: https://crrev.com/e37fbcc3ea6437a0fe0b5d59204839879e3c69c6 Cr-Commit-Position: refs/heads/master@{#40132}

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -54 lines) Patch
M src/heap/spaces.h View 1 6 chunks +12 lines, -33 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Lippautz
4 years, 2 months ago (2016-10-10 16:32:54 UTC) #3
ulan
lgtm, thanks!
4 years, 2 months ago (2016-10-10 16:33:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409553003/20001
4 years, 2 months ago (2016-10-10 16:34:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 17:02:15 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 17:02:29 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e37fbcc3ea6437a0fe0b5d59204839879e3c69c6
Cr-Commit-Position: refs/heads/master@{#40132}

Powered by Google App Engine
This is Rietveld 408576698