Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: src/builtins/builtins.h

Issue 2409513003: [regexp] Port remaining JS functions in regexp.js (Closed)
Patch Set: Format and Rebaseline Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/builtins/builtins.h
diff --git a/src/builtins/builtins.h b/src/builtins/builtins.h
index 088732e8f90f1fd5320083b88d3eb7e7543892e2..7bb36d2577cba0d32c98e2a6de89af9680438869 100644
--- a/src/builtins/builtins.h
+++ b/src/builtins/builtins.h
@@ -575,8 +575,12 @@ namespace internal {
CPP(RegExpCapture8Getter) \
CPP(RegExpCapture9Getter) \
CPP(RegExpConstructor) \
+ CPP(RegExpInitialize) \
+ TFJ(RegExpInternalMatch, 3) \
+ TFJ(RegExpInternalReplace, 4) \
Yang 2016/10/13 11:51:11 I would have implemented internal match and replac
jgruber 2016/10/13 12:02:38 It's explained in the commit message why these two
CPP(RegExpInputGetter) \
CPP(RegExpInputSetter) \
+ CPP(RegExpIsRegExp) \
CPP(RegExpLastMatchGetter) \
CPP(RegExpLastParenGetter) \
CPP(RegExpLeftContextGetter) \

Powered by Google App Engine
This is Rietveld 408576698