GTTF: Add ReadOnlyRietveld similar to one currently in CQ codebase.

rietveld.py

 # coding: utf-8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Defines class Rietveld to easily access a rietveld instance.
 
 Security implications:
 
 The following hypothesis are made:
 - Rietveld enforces:
@@ skipping 427 matching lines @@
     if not messages:
       # Assumes self._lookup uses deepcopy.
       del data['messages']
     return data
 
   def get_patchset_properties(self, issue, patchset):
     return self._lookup(
         'get_patchset_properties',
         (issue, patchset),
         super(CachingRietveld, self).get_patchset_properties)
+
+
+class ReadOnlyRietveld(Rietveld):

[Isaac (away), 2013/09/14 07:48:08]

I think maybe this should not extend rietveld -- that seems like a recipe for
failure, if we accidentally use a base method which is not read only.  Perhaps
we could instantiate a private rietveld instance instead.

[Paweł Hajdan Jr., 2013/09/16 14:33:52]

Sounds good to me - I'll probably do that on Thursday or maybe earlier if time
allows. Thanks for sharing that idea, I like it.

[M-A Ruel, 2013/09/16 14:53:05]

Technically, you could just zap POST and be fine. But I don't mind either way.

+  """Only provides read operations, and simulates writes locally."""
+
+  # Dictionary of local changes, indexed by issue number as int.
+  _local_changes = {}
+
+  def __init__(self, *args, **kwargs):
+    super(ReadOnlyRietveld, self).__init__(*args, **kwargs)
+
+  def close_issue(self, issue):
+    logging.info('ReadOnlyRietveld: closing issue %d' % issue)
+    ReadOnlyRietveld._local_changes.setdefault(issue, {})['closed'] = True
+
+  def get_issue_properties(self, issue, messages):
+    data = super(ReadOnlyRietveld, self).get_issue_properties(issue, messages)
+    data.update(ReadOnlyRietveld._local_changes.get(issue, {}))
+    return data
+
+  def update_description(self, issue, description):
+    logging.info('ReadOnlyRietveld: new description for issue %d: %s' %
+        (issue, description))
+
+  def add_comment(self, issue, message, add_as_reviewer=False):
+    logging.info('ReadOnlyRietveld: posting comment "%s" to issue %d' %
+        (message, issue))
+
+  def set_flag(self, issue, patchset, flag, value):
+    logging.info('ReadOnlyRietveld: setting flag "%s" to "%s" for issue %d' %
+        (flag, value, issue))
+    ReadOnlyRietveld._local_changes.setdefault(issue, {})[flag] = value
+
+  def trigger_try_jobs(
+      self, issue, patchset, reason, clobber, revision, builders_and_tests):
+    logging.info('ReadOnlyRietveld: triggering try jobs %r for issue %d' %
+        (builders_and_tests, issue))