Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5278)

Unified Diff: chrome/android/webapk/shell_apk/AndroidManifest.xml

Issue 2409483002: Read the bare minimum of data from the WebAPK launch intent. (Closed)
Patch Set: Merge branch 'startup_crash0' into security Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/shell_apk/AndroidManifest.xml
diff --git a/chrome/android/webapk/shell_apk/AndroidManifest.xml b/chrome/android/webapk/shell_apk/AndroidManifest.xml
index 7f5e86271696391041fdab2e1d5c6b4188a35bcc..7018924b0b85f499c6299b34bd83688ffa705cd9 100644
--- a/chrome/android/webapk/shell_apk/AndroidManifest.xml
+++ b/chrome/android/webapk/shell_apk/AndroidManifest.xml
@@ -40,11 +40,13 @@
<meta-data android:name="org.chromium.webapk.shell_apk.runtimeHost" android:value="{{ runtime_host }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.startUrl" android:value="{{ start_url }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.name" android:value="{{ name }}" />
+ <meta-data android:name="org.chromium.webapk.shell_apk.shortName" android:value="{{ short_name }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.scope" android:value="{{ scope_url }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.displayMode" android:value="{{ display_mode }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.orientation" android:value="{{ orientation }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.themeColor" android:value="{{ theme_color }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.backgroundColor" android:value="{{ background_color }}" />
+ <meta-data android:name="org.chromium.webapk.shell_apk.iconId" android:resource="@mipmap/app_icon" />
<meta-data android:name="org.chromium.webapk.shell_apk.iconUrl" android:value="{{ icon_url }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.iconMurmur2Hash" android:value="{{ icon_murmur2_hash }}" />
<meta-data android:name="org.chromium.webapk.shell_apk.webManifestUrl" android:value="{{ web_manifest_url }}" />

Powered by Google App Engine
This is Rietveld 408576698