Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2409473002: Fix more tests on windows bots (Closed)

Created:
4 years, 2 months ago by Brian Wilkerson
Modified:
4 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -27 lines) Patch
M pkg/analyzer/test/src/context/context_test.dart View 8 chunks +15 lines, -10 lines 0 comments Download
M pkg/analyzer/test/src/context/mock_sdk.dart View 5 chunks +13 lines, -8 lines 0 comments Download
M pkg/analyzer/test/src/dart/sdk/sdk_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/task/strong/strong_test_helper.dart View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 2 months ago (2016-10-09 17:30:17 UTC) #2
scheglov
LGTM
4 years, 2 months ago (2016-10-09 17:39:14 UTC) #3
Brian Wilkerson
4 years, 2 months ago (2016-10-09 18:59:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
514f611dba9064485fd6075c977527e527fa8fca (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698