Fix crash on WebAPK startup

Fix crash on WebAPK startup

This CL fixes a crash in WebApkUpdateManager#onBuiltWebApk() on startup when
updating the WebAPK fails. When updating the WebAPK fails,
WebApkInstaller::OnFailure() calls the callback with an empty package name. This
causes an empty package name to be incorrectly  used to construct the WebAPK id
in WebApkUpdateManager#onBuiltWebApk()

BUG=654251
Committed: https://crrev.com/7ba820fdf3fd1c56cc1796a995be3a103c1704f9
Cr-Commit-Position: refs/heads/master@{#424811}

[pkotwicz, 2016-10-09 04:32:06]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2016-10-09 04:32:07]

Dominick, can you please take a look?

[dominickn, 2016-10-10 06:05:38]

https://codereview.chromium.org/2409453002/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapk/webapk_installer.cc (right):

https://codereview.chromium.org/2409453002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/webapk_installer.cc:495: FinishCallback callback =
finish_callback_;
Any particular reason this needs to be deleted before running the callback?
Could you do:

callback.Run(false, webapk_package_);
delete this;

(same with other locations)

https://codereview.chromium.org/2409453002/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapk/webapk_update_manager.h (right):

https://codereview.chromium.org/2409453002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/webapk_update_manager.h:21: // |success| indicates
whether the request was issued to the server. A "true"
Minor nit: reflow this comment.

[pkotwicz, 2016-10-10 16:42:01]

Dominick, can you please take another look?

https://codereview.chromium.org/2409453002/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapk/webapk_installer.cc (right):

https://codereview.chromium.org/2409453002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/webapk_installer.cc:495: FinishCallback callback =
finish_callback_;
There is no particular reason. Changed as requested

https://codereview.chromium.org/2409453002/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapk/webapk_update_manager.h (right):

https://codereview.chromium.org/2409453002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/webapk_update_manager.h:21: // |success| indicates
whether the request was issued to the server. A "true"
What do you mean? Are you suggesting that there should be no new line before
|success|?

[dominickn, 2016-10-11 04:54:05]

lgtm

https://codereview.chromium.org/2409453002/diff/1/chrome/browser/android/weba...
File chrome/browser/android/webapk/webapk_update_manager.h (right):

https://codereview.chromium.org/2409453002/diff/1/chrome/browser/android/weba...
chrome/browser/android/webapk/webapk_update_manager.h:21: // |success| indicates
whether the request was issued to the server. A "true"
On 2016/10/10 16:42:01, pkotwicz wrote:
> What do you mean? Are you suggesting that there should be no new line before
> |success|?

Yes, that's what I meant. Pretty minor, feel free to fix it next time you're in
this code.

[pkotwicz, 2016-10-12 18:24:46]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-10-12 18:24:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2409453002/#ps40001
(title: "Merge branch 'master' into startup_crash0")

[commit-bot: I haz the power, 2016-10-12 18:25:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-12 19:06:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-12 19:07:50]

Description was changed from

==========
Fix crash on WebAPK startup

This CL fixes a crash in WebApkUpdateManager#onBuiltWebApk() on startup when
updating the WebAPK fails. When updating the WebAPK fails,
WebApkInstaller::OnFailure() calls the callback with an empty package name. This
causes an empty package name to be incorrectly  used to construct the WebAPK id
in WebApkUpdateManager#onBuiltWebApk()

BUG=654251
==========

to

==========
Fix crash on WebAPK startup

This CL fixes a crash in WebApkUpdateManager#onBuiltWebApk() on startup when
updating the WebAPK fails. When updating the WebAPK fails,
WebApkInstaller::OnFailure() calls the callback with an empty package name. This
causes an empty package name to be incorrectly  used to construct the WebAPK id
in WebApkUpdateManager#onBuiltWebApk()

BUG=654251

Committed: https://crrev.com/7ba820fdf3fd1c56cc1796a995be3a103c1704f9
Cr-Commit-Position: refs/heads/master@{#424811}
==========

[commit-bot: I haz the power, 2016-10-12 19:07:51]

Patchset 3 (id:??) landed as
https://crrev.com/7ba820fdf3fd1c56cc1796a995be3a103c1704f9
Cr-Commit-Position: refs/heads/master@{#424811}