chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm - Issue 2409443002: Make GlobalErrorService's ownership model slightly less insane.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

Issue 2409443002: Make GlobalErrorService's ownership model slightly less insane. (Closed)

Patch Set: windows, ownership Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/sync_global_error.cc ('K') | « chrome/browser/sync/sync_global_error.cc ('k') | chrome/browser/ui/global_error/global_error_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm b/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

index a74888cf0e51183eece535b7cbf4f1e30ffff14b..acb42cb462535d760de91c713afb30f2d5d7618a 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

@@ -12,6 +12,7 @@

#include "base/callback.h"

#include "base/callback_helpers.h"

#include "base/macros.h"

+#include "base/memory/ptr_util.h"

#include "base/strings/stringprintf.h"

#include "base/strings/utf_string_conversions.h"

#include "base/threading/thread_task_runner_handle.h"

@@ -484,7 +485,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionButtonUiTest,

// up the overflow container's bounds (crbug.com/511326).

GlobalErrorService* error_service =

GlobalErrorServiceFactory::GetForProfile(profile());

- error_service->AddGlobalError(new MenuError());

+ error_service->AddOwnedGlobalError(base::MakeUnique<MenuError>());

// It's probably excessive to test every level of the overflow here. Test

// having all actions overflowed, some actions overflowed, and one action

« chrome/browser/sync/sync_global_error.cc ('K') | « chrome/browser/sync/sync_global_error.cc ('k') | chrome/browser/ui/global_error/global_error_service.h » ('j') | no next file with comments »