Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6606)

Unified Diff: chrome/browser/ui/toolbar/app_menu_model_unittest.cc

Issue 2409443002: Make GlobalErrorService's ownership model slightly less insane. (Closed)
Patch Set: commentary Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/global_error/global_error_service_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/app_menu_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/app_menu_model_unittest.cc b/chrome/browser/ui/toolbar/app_menu_model_unittest.cc
index cbbd6774a3bff84f45df95e2963b8835130658fb..5a3731c29ca550db751e35ce7dd3a4f4d40fad0b 100644
--- a/chrome/browser/ui/toolbar/app_menu_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/app_menu_model_unittest.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/ui/toolbar/app_menu_model.h"
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "chrome/app/chrome_command_ids.h"
#include "chrome/browser/defaults.h"
#include "chrome/browser/prefs/browser_prefs.h"
@@ -179,13 +180,11 @@ TEST_F(AppMenuModelTest, GlobalError) {
GlobalErrorServiceFactory::GetForProfile(browser()->profile());
ProfileOAuth2TokenServiceFactory::GetForProfile(browser()->profile());
const int command1 = 1234567;
- // AddGlobalError takes ownership of error1.
MenuError* error1 = new MenuError(command1);
- service->AddGlobalError(error1);
+ service->AddGlobalError(base::WrapUnique(error1));
const int command2 = 1234568;
- // AddGlobalError takes ownership of error2.
MenuError* error2 = new MenuError(command2);
- service->AddGlobalError(error2);
+ service->AddGlobalError(base::WrapUnique(error2));
AppMenuModel model(this, browser());
int index1 = model.GetIndexOfCommandId(command1);
« no previous file with comments | « chrome/browser/ui/global_error/global_error_service_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698