Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: chrome/browser/extensions/external_install_error.cc

Issue 2409443002: Make GlobalErrorService's ownership model slightly less insane. (Closed)
Patch Set: commentary Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_install_error.cc
diff --git a/chrome/browser/extensions/external_install_error.cc b/chrome/browser/extensions/external_install_error.cc
index aa17a9488da1854e01f8ce98a20575afd5069cb2..caca9ef90d777596c224628ee6d1dd13611fcade 100644
--- a/chrome/browser/extensions/external_install_error.cc
+++ b/chrome/browser/extensions/external_install_error.cc
@@ -313,7 +313,7 @@ ExternalInstallError::ExternalInstallError(
ExternalInstallError::~ExternalInstallError() {
if (global_error_.get())
- error_service_->RemoveGlobalError(global_error_.get());
+ error_service_->RemoveUnownedGlobalError(global_error_.get());
}
void ExternalInstallError::OnInstallPromptDone(
@@ -439,7 +439,7 @@ void ExternalInstallError::OnDialogReady(
if (alert_type_ == BUBBLE_ALERT) {
global_error_.reset(new ExternalInstallBubbleAlert(this, prompt_.get()));
- error_service_->AddGlobalError(global_error_.get());
+ error_service_->AddUnownedGlobalError(global_error_.get());
if (!manager_->has_currently_visible_install_alert()) {
// |browser| is nullptr during unit tests, so call
@@ -454,7 +454,7 @@ void ExternalInstallError::OnDialogReady(
} else {
DCHECK(alert_type_ == MENU_ALERT);
global_error_.reset(new ExternalInstallMenuAlert(this));
- error_service_->AddGlobalError(global_error_.get());
+ error_service_->AddUnownedGlobalError(global_error_.get());
}
}
« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui.cc ('k') | chrome/browser/extensions/warning_badge_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698