Make GlobalErrorService's ownership model slightly less insane.

chrome/browser/ui/cocoa/extensions/browser_action_button_interactive_uitest.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/browser_action_button.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/callback_helpers.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/extensions/extension_action_test_util.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/ui/browser_window.h"
 #import "chrome/browser/ui/cocoa/app_menu/app_menu_controller.h"
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 #import "chrome/browser/ui/cocoa/extensions/browser_actions_container_view.h"
@@ skipping 452 matching lines @@
   };
 
   // Test the layout with gradually more extensions hidden.
   for (int i = 1; i <= kNumExtensions; ++i)
     resizeAndActivateAppMenu(i, base::StringPrintf("Normal: %d", i));
 
   // Adding a global error adjusts the app menu size, and has been known to mess
   // up the overflow container's bounds (crbug.com/511326).
   GlobalErrorService* error_service =
       GlobalErrorServiceFactory::GetForProfile(profile());
-  error_service->AddGlobalError(new MenuError());
+  error_service->AddGlobalError(base::MakeUnique<MenuError>());
 
   // It's probably excessive to test every level of the overflow here. Test
   // having all actions overflowed, some actions overflowed, and one action
   // overflowed.
   resizeAndActivateAppMenu(kNumExtensions, "GlobalError Full");
   resizeAndActivateAppMenu(kNumExtensions / 2, "GlobalError Half");
   resizeAndActivateAppMenu(1, "GlobalError One");
 }
 
 void AddExtensionWithMenuOpen(ToolbarController* toolbarController,
@@ skipping 144 matching lines @@
   openAndCloseAppMenu(appMenuController());
 
   // Move the extension back to the main bar, so an overflow bar is no longer
   // needed. Then open and close the app menu a couple times.
   // This tests that the menu properly cleans up after itself when an overflow
   // was present, and is no longer (fix for crbug.com/603241).
   model()->SetVisibleIconCount(1);
   openAndCloseAppMenu(appMenuController());
   openAndCloseAppMenu(appMenuController());
 }