Make GlobalErrorService's ownership model slightly less insane.

chrome/browser/sync/sync_global_error.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/sync_global_error.h"
 
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/sync/sync_ui_util.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
@@ skipping 12 matching lines @@
     LoginUIService* login_ui_service,
     syncer::SyncErrorController* error_controller,
     browser_sync::ProfileSyncService* profile_sync_service)
     : global_error_service_(global_error_service),
       login_ui_service_(login_ui_service),
       error_controller_(error_controller),
       sync_service_(profile_sync_service) {
   DCHECK(sync_service_);
   error_controller_->AddObserver(this);
   if (!switches::IsMaterialDesignUserMenu())
-    global_error_service_->AddGlobalError(this);
+    global_error_service_->AddUnownedGlobalError(this);
 }
 
 SyncGlobalError::~SyncGlobalError() {
   DCHECK(!error_controller_)
       << "SyncGlobalError::Shutdown() was not called";
 }
 
 void SyncGlobalError::Shutdown() {
   if (!switches::IsMaterialDesignUserMenu())
-    global_error_service_->RemoveGlobalError(this);
+    global_error_service_->RemoveUnownedGlobalError(this);
   error_controller_->RemoveObserver(this);
   error_controller_ = nullptr;
 }
 
 bool SyncGlobalError::HasMenuItem() {
   return !menu_label_.empty();
 }
 
 int SyncGlobalError::MenuItemCommandID() {
   return IDC_SHOW_SYNC_ERROR;
@@ skipping 61 matching lines @@
 
   if (menu_label != menu_label_ || bubble_message != bubble_message_ ||
       bubble_accept_label != bubble_accept_label_) {
     menu_label_ = menu_label;
     bubble_message_ = bubble_message;
     bubble_accept_label_ = bubble_accept_label;
 
     global_error_service_->NotifyErrorsChanged(this);
   }
 }