Make GlobalErrorService's ownership model slightly less insane.

chrome/browser/extensions/warning_badge_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/warning_badge_service.h"
 
 #include <stddef.h>
 
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/stl_util.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/warning_badge_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/global_error/global_error.h"
 #include "chrome/browser/ui/global_error/global_error_service.h"
 #include "chrome/browser/ui/global_error/global_error_service_factory.h"
 #include "chrome/grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
@@ skipping 127 matching lines @@
   ShowBadge(non_suppressed_warnings_exist);
 }
 
 void WarningBadgeService::ShowBadge(bool show) {
   GlobalErrorService* service =
       GlobalErrorServiceFactory::GetForProfile(profile_);
   GlobalError* error = service->GetGlobalErrorByMenuItemCommandID(
       ErrorBadge::GetMenuItemCommandID());
 
   // Activate or hide the warning badge in case the current state is incorrect.
-  if (error && !show) {
+  if (error && !show)
     service->RemoveGlobalError(error);
-    delete error;
-  } else if (!error && show) {
-    service->AddGlobalError(new ErrorBadge(this));
-  }
+  else if (!error && show)
+    service->AddGlobalError(base::MakeUnique<ErrorBadge>(this));
 }
 
 }  // namespace extensions