Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 2409433002: Revert of Add loading mobile story set (Closed)

Created:
4 years, 2 months ago by Zhen Wang
Modified:
4 years, 2 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, dtu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add loading mobile story set (patchset #6 id:140001 of https://codereview.chromium.org/2363343003/ ) Reason for revert: Failure on Android Perf bot BUG=chromium:654215 Original issue's description: > Add loading mobile story set > > This adds a story set and corresponding benchmark for mobile loading > performance loading team is interested in. > > Design doc: https://docs.google.com/document/d/1QKlZIoURAxZk-brrXsKYZl9O8ieqXht3ogeF9yLNFCI/edit > > BUG=643524 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > Committed: https://crrev.com/31d0a108f1783a04f2b981d668883a43a30ddc32 > Cr-Commit-Position: refs/heads/master@{#423993} TBR=kouhei@chromium.org,nednguyen@google.com,ksakamoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=643524 Committed: https://crrev.com/b524efc65e507803ec42e4d73509c420cb715081 Cr-Commit-Position: refs/heads/master@{#424083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -239 lines) Patch
M tools/perf/OWNERS View 1 chunk +1 line, -1 line 0 comments Download
D tools/perf/benchmarks/loading.py View 1 chunk +0 lines, -28 lines 0 comments Download
M tools/perf/benchmarks/page_cycler_v2.py View 1 chunk +22 lines, -26 lines 0 comments Download
D tools/perf/page_sets/data/loading_mobile.json View 1 chunk +0 lines, -60 lines 0 comments Download
D tools/perf/page_sets/data/loading_mobile_000.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/data/loading_mobile_001.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D tools/perf/page_sets/loading_mobile.py View 1 chunk +0 lines, -122 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Zhen Wang
Created Revert of Add loading mobile story set
4 years, 2 months ago (2016-10-08 17:32:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2409433002/1
4 years, 2 months ago (2016-10-08 17:32:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-08 17:34:38 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 17:36:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b524efc65e507803ec42e4d73509c420cb715081
Cr-Commit-Position: refs/heads/master@{#424083}

Powered by Google App Engine
This is Rietveld 408576698