chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc - Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

Issue 2409423005: Compare GURLs to kUrlConstants with .spec() and string equality (Closed)

Patch Set: rebase on dependent patch Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

diff --git a/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc b/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

index 5ad6c3ea16865e83fd72c61ca3f7b879aa5bb436..d20b8aafc887f834fdbe540318ef29f1f39eda0d 100644

--- a/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

+++ b/chrome/renderer/printing/chrome_print_web_view_helper_delegate.cc

@@ -43,8 +43,7 @@ blink::WebElement ChromePrintWebViewHelperDelegate::GetPdfElement(

blink::WebLocalFrame* frame) {

#if defined(ENABLE_EXTENSIONS)

GURL url = frame->document().url();

- bool inside_print_preview =

- url.GetOrigin() == GURL(chrome::kChromeUIPrintURL);

+ bool inside_print_preview = url.GetOrigin() == chrome::kChromeUIPrintURL;

bool inside_pdf_extension = url.SchemeIs(extensions::kExtensionScheme) &&

url.host() == extension_misc::kPdfExtensionId;

if (inside_print_preview || inside_pdf_extension) {